Refactorings on the Trust code. (Extracted an interface and added javadoc.)
authorwassa <wassa@ab3bd59b-922f-494d-bb5f-6f0a3c29deca>
Thu, 7 Apr 2005 04:18:54 +0000 (04:18 +0000)
committerwassa <wassa@ab3bd59b-922f-494d-bb5f-6f0a3c29deca>
Thu, 7 Apr 2005 04:18:54 +0000 (04:18 +0000)
git-svn-id: https://subversion.switch.ch/svn/shibboleth/java-idp/trunk@1383 ab3bd59b-922f-494d-bb5f-6f0a3c29deca

src/edu/internet2/middleware/shibboleth/common/Trust.java
src/edu/internet2/middleware/shibboleth/common/provider/BasicTrust.java [new file with mode: 0644]
src/edu/internet2/middleware/shibboleth/common/provider/ShibbolethTrust.java
src/edu/internet2/middleware/shibboleth/idp/IdPProtocolSupport.java
tests/edu/internet2/middleware/shibboleth/common/TrustTests.java

index e473111..3ac72e4 100644 (file)
 
 package edu.internet2.middleware.shibboleth.common;
 
-import java.security.cert.CertificateEncodingException;
 import java.security.cert.X509Certificate;
-import java.util.Arrays;
-import java.util.Iterator;
 
-import org.apache.log4j.Logger;
-import org.apache.xml.security.keys.KeyInfo;
-import org.apache.xml.security.keys.keyresolver.KeyResolverException;
-
-import edu.internet2.middleware.shibboleth.metadata.KeyDescriptor;
 import edu.internet2.middleware.shibboleth.metadata.RoleDescriptor;
 
 /**
+ * Defines methodology for determing whether or not a system entity should trust the messages issued by another.
+ * 
  * @author Walter Hoehn
  */
-public class Trust {
-
-       private static Logger log = Logger.getLogger(Trust.class.getName());
-
-       public boolean validate(RoleDescriptor descriptor, X509Certificate[] certificateChain, int keyUse) {
-
-               if (descriptor == null || certificateChain == null || certificateChain.length < 1) {
-                       log.error("Appropriate data was not supplied for trust evaluation.");
-                       return false;
-               }
-
-               // Iterator through all the keys in the metadata
-               Iterator keyDescriptors = descriptor.getKeyDescriptors();
-               while (keyDescriptors.hasNext()) {
-                       // Look for a key descriptor with the right usage bits
-                       KeyDescriptor keyDescriptor = (KeyDescriptor) keyDescriptors.next();
-                       if (keyDescriptor.getUse() != KeyDescriptor.UNSPECIFIED && keyDescriptor.getUse() != keyUse) {
-                               log.debug("Role contains a key descriptor, but the usage specification is not valid for this action.");
-                               continue;
-                       }
-
-                       // We found one, attempt to do an exact match between the metadata certificate
-                       // and the supplied end-entity certificate
-                       KeyInfo keyInfo = keyDescriptor.getKeyInfo();
-                       if (keyInfo.containsX509Data()) {
-                               log.debug("Attempting to match X509 certificate.");
-                               try {
-                                       X509Certificate metaCert = keyInfo.getX509Certificate();
-                                       if (certificateChain != null && certificateChain.length > 0
-                                                       && Arrays.equals(metaCert.getEncoded(), certificateChain[0].getEncoded())) {
-                                               log.debug("Match successful.");
-                                               return true;
-                                       } else {
-                                               log.debug("Certificate did not match.");
-                                       }
-
-                               } catch (KeyResolverException e) {
-                                       log.error("Error extracting X509 certificate from metadata.");
-                               } catch (CertificateEncodingException e) {
-                                       log.error("Error while comparing X509 encoded data.");
-                               }
-                       }
-               }
-               return false;
-       }
-}
+public interface Trust {
+
+       /**
+        * Verifies that a certificate or ordered chain of certificates represents a valid credential set for a specific
+        * action by a specific entity.
+        * 
+        * @param descriptor
+        *            the SAML 2 role descriptor of the entity purported to be performing the action
+        * @param certificateChain
+        *            the credentials supplied by the entity (if this contains a certificate chain, it should be ordered
+        *            with the end-entity certificate first
+        * @param keyUse
+        *            the action being performed (must be valid <code>KeyDescriptor</code> usage type
+        * @return true if the validation was successful and false if it was not successful
+        */
+       public boolean validate(RoleDescriptor descriptor, X509Certificate[] certificateChain, int keyUse);
+}
\ No newline at end of file
diff --git a/src/edu/internet2/middleware/shibboleth/common/provider/BasicTrust.java b/src/edu/internet2/middleware/shibboleth/common/provider/BasicTrust.java
new file mode 100644 (file)
index 0000000..17be741
--- /dev/null
@@ -0,0 +1,95 @@
+/*
+ * The Shibboleth License, Version 1. Copyright (c) 2002 University Corporation for Advanced Internet Development, Inc.
+ * All rights reserved Redistribution and use in source and binary forms, with or without modification, are permitted
+ * provided that the following conditions are met: Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer. Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials
+ * provided with the distribution, if any, must include the following acknowledgment: "This product includes software
+ * developed by the University Corporation for Advanced Internet Development <http://www.ucaid.edu> Internet2 Project.
+ * Alternately, this acknowledegement may appear in the software itself, if and wherever such third-party
+ * acknowledgments normally appear. Neither the name of Shibboleth nor the names of its contributors, nor Internet2, nor
+ * the University Corporation for Advanced Internet Development, Inc., nor UCAID may be used to endorse or promote
+ * products derived from this software without specific prior written permission. For written permission, please contact
+ * shibboleth@shibboleth.org Products derived from this software may not be called Shibboleth, Internet2, UCAID, or the
+ * University Corporation for Advanced Internet Development, nor may Shibboleth appear in their name, without prior
+ * written permission of the University Corporation for Advanced Internet Development. THIS SOFTWARE IS PROVIDED BY THE
+ * COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND WITH ALL FAULTS. ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE, AND NON-INFRINGEMENT ARE
+ * DISCLAIMED AND THE ENTIRE RISK OF SATISFACTORY QUALITY, PERFORMANCE, ACCURACY, AND EFFORT IS WITH LICENSEE. IN NO
+ * EVENT SHALL THE COPYRIGHT OWNER, CONTRIBUTORS OR THE UNIVERSITY CORPORATION FOR ADVANCED INTERNET DEVELOPMENT, INC.
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
+ * OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+package edu.internet2.middleware.shibboleth.common.provider;
+
+import java.security.cert.CertificateEncodingException;
+import java.security.cert.X509Certificate;
+import java.util.Arrays;
+import java.util.Iterator;
+
+import org.apache.log4j.Logger;
+import org.apache.xml.security.keys.KeyInfo;
+import org.apache.xml.security.keys.keyresolver.KeyResolverException;
+
+import edu.internet2.middleware.shibboleth.common.Trust;
+import edu.internet2.middleware.shibboleth.metadata.KeyDescriptor;
+import edu.internet2.middleware.shibboleth.metadata.RoleDescriptor;
+
+/**
+ * <code>Trust</code> implementation that validates against standard inline keying data within SAML 2 metadata.
+ * 
+ * @author Walter Hoehn
+ */
+public class BasicTrust implements Trust {
+
+       private static Logger log = Logger.getLogger(BasicTrust.class.getName());
+
+       /*
+        * @see edu.internet2.middleware.shibboleth.common.Trust#validate(edu.internet2.middleware.shibboleth.metadata.RoleDescriptor,
+        *      java.security.cert.X509Certificate[], int)
+        */
+       public boolean validate(RoleDescriptor descriptor, X509Certificate[] certificateChain, int keyUse) {
+
+               if (descriptor == null || certificateChain == null || certificateChain.length < 1) {
+                       log.error("Appropriate data was not supplied for trust evaluation.");
+                       return false;
+               }
+
+               // Iterator through all the keys in the metadata
+               Iterator keyDescriptors = descriptor.getKeyDescriptors();
+               while (keyDescriptors.hasNext()) {
+                       // Look for a key descriptor with the right usage bits
+                       KeyDescriptor keyDescriptor = (KeyDescriptor) keyDescriptors.next();
+                       if (keyDescriptor.getUse() != KeyDescriptor.UNSPECIFIED && keyDescriptor.getUse() != keyUse) {
+                               log.debug("Role contains a key descriptor, but the usage specification is not valid for this action.");
+                               continue;
+                       }
+
+                       // We found one, attempt to do an exact match between the metadata certificate
+                       // and the supplied end-entity certificate
+                       KeyInfo keyInfo = keyDescriptor.getKeyInfo();
+                       if (keyInfo.containsX509Data()) {
+                               log.debug("Attempting to match X509 certificate.");
+                               try {
+                                       X509Certificate metaCert = keyInfo.getX509Certificate();
+                                       if (certificateChain != null && certificateChain.length > 0
+                                                       && Arrays.equals(metaCert.getEncoded(), certificateChain[0].getEncoded())) {
+                                               log.debug("Match successful.");
+                                               return true;
+                                       } else {
+                                               log.debug("Certificate did not match.");
+                                       }
+
+                               } catch (KeyResolverException e) {
+                                       log.error("Error extracting X509 certificate from metadata.");
+                               } catch (CertificateEncodingException e) {
+                                       log.error("Error while comparing X509 encoded data.");
+                               }
+                       }
+               }
+               return false;
+       }
+}
\ No newline at end of file
index e0bb0e9..433b1b8 100644 (file)
@@ -67,13 +67,20 @@ import edu.internet2.middleware.shibboleth.metadata.KeyDescriptor;
 import edu.internet2.middleware.shibboleth.metadata.RoleDescriptor;
 
 /**
+ * <code>Trust</code> implementation that does PKIX validation against key authorities included in shibboleth-specific
+ * extensions to SAML 2 metadata.
+ * 
  * @author Walter Hoehn
  */
-public class ShibbolethTrust extends Trust {
+public class ShibbolethTrust extends BasicTrust implements Trust {
 
        private static Logger log = Logger.getLogger(ShibbolethTrust.class.getName());
        private static Pattern regex = Pattern.compile(".*?CN=([^,/]+).*");
 
+       /*
+        * @see edu.internet2.middleware.shibboleth.common.Trust#validate(edu.internet2.middleware.shibboleth.metadata.RoleDescriptor,
+        *      java.security.cert.X509Certificate[], int)
+        */
        public boolean validate(RoleDescriptor descriptor, X509Certificate[] certificateChain, int keyUse) {
 
                // If we can successfully validate with an inline key, that's fine
index 89ec691..fda659c 100644 (file)
@@ -54,8 +54,8 @@ import edu.internet2.middleware.shibboleth.common.NameMapper;
 import edu.internet2.middleware.shibboleth.common.RelyingParty;
 import edu.internet2.middleware.shibboleth.common.ServiceProviderMapper;
 import edu.internet2.middleware.shibboleth.common.ShibbolethConfigurationException;
-import edu.internet2.middleware.shibboleth.common.Trust;
 import edu.internet2.middleware.shibboleth.common.provider.ShibbolethTrust;
+import edu.internet2.middleware.shibboleth.common.Trust;
 import edu.internet2.middleware.shibboleth.metadata.EntityDescriptor;
 import edu.internet2.middleware.shibboleth.metadata.Metadata;
 import edu.internet2.middleware.shibboleth.metadata.MetadataException;
index ea8d688..6c50a40 100644 (file)
@@ -40,6 +40,7 @@ import org.apache.log4j.Level;
 import org.apache.log4j.Logger;
 
 import edu.internet2.middleware.shibboleth.common.ShibResource.ResourceNotAvailableException;
+import edu.internet2.middleware.shibboleth.common.provider.BasicTrust;
 import edu.internet2.middleware.shibboleth.common.provider.ShibbolethTrust;
 import edu.internet2.middleware.shibboleth.metadata.EntityDescriptor;
 import edu.internet2.middleware.shibboleth.metadata.KeyDescriptor;
@@ -94,7 +95,7 @@ public class TrustTests extends TestCase {
                        X509Certificate cert = (X509Certificate) keyStore.getCertificate("inliine1");
 
                        // Try to validate against the metadata
-                       Trust validator = new Trust();
+                       Trust validator = new BasicTrust();
                        boolean successful = validator.validate(role, new X509Certificate[]{cert}, KeyDescriptor.ENCRYPTION);
                        if (!successful) {
                                fail("Validation should have succeeded.");
@@ -131,7 +132,7 @@ public class TrustTests extends TestCase {
                        X509Certificate cert = (X509Certificate) keyStore.getCertificate("inline2");
 
                        // Try to validate against the metadata
-                       Trust validator = new Trust();
+                       Trust validator = new BasicTrust();
                        boolean successful = validator.validate(role, new X509Certificate[]{cert}, KeyDescriptor.ENCRYPTION);
                        if (successful) {
                                fail("Validation should have failed.");
@@ -262,7 +263,7 @@ public class TrustTests extends TestCase {
                        fail("Error in test specification: " + e);
                }
        }
-       
+
        public void testPkixX509CertFailValidateWithPathTooLong() {
 
                try {