Based on unit test, proper response to nulls is an exception.

git-svn-id: https://subversion.switch.ch/svn/shibboleth/java-idp/trunk@998 ab3bd59b-922f-494d-bb5f-6f0a3c29deca

diff --git a/src/edu/internet2/middleware/shibboleth/aa/arp/provider/ExactSharMatchFunction.java b/src/edu/internet2/middleware/shibboleth/aa/arp/provider/ExactSharMatchFunction.java
index 56c5612..c4af6d2 100755 (executable)
--- a/src/edu/internet2/middleware/shibboleth/aa/arp/provider/ExactSharMatchFunction.java
+++ b/src/edu/internet2/middleware/shibboleth/aa/arp/provider/ExactSharMatchFunction.java
@@ -69,7 +69,8 @@ public class ExactSharMatchFunction implements MatchFunction {
                throws MatchingException
        {
                if (arpComponent == null || requestComponent == null) {
-                       return false;
+            log.error("Invalid use of ARP matching function (ExacthSharMatchFunction). One of the operands was null.");
+            throw new MatchingException("Invalid use of ARP matching function (ExacthSharMatchFunction).");
                }
                else if (!(arpComponent instanceof String) || !(requestComponent instanceof String)) {
                        log.error("Invalid use of ARP matching function (ExacthSharMatchFunction). arpComponent: (" + arpComponent + "). requestComponent: (" + requestComponent + ").");